Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'goto definition' #3

Closed
runxel opened this issue Aug 26, 2021 · 6 comments
Closed

Support 'goto definition' #3

runxel opened this issue Aug 26, 2021 · 6 comments
Labels
enhancement New feature or request
Milestone
v25.2

Comments

@runxel
Copy link
Contributor

runxel commented Aug 26, 2021

Nice to have the outline, but it would be great if we could support the "goto definition" function of VSC as well.
This is especially helpful when having a lot of subroutines.
We could then place the cursor in the name and use the "goto definition" function to go to the subroutine in a fast way. Would speed up daily development for sure!
@pbaksa pbaksa added the enhancement New feature or request label Nov 2, 2021
@pbaksa pbaksa added this to the v25.2 milestone Nov 2, 2021
@pbaksa pbaksa closed this as completed Nov 29, 2021
@pbaksa
Copy link
Contributor

pbaksa commented Nov 29, 2021

Thank you for contributing!

@runxel
Copy link
Contributor Author

runxel commented Nov 29, 2021

Sure!
What do I have to do to enable this function in v.1.25.2?
It does not seem to work for me....

@pbaksa
Copy link
Contributor

pbaksa commented Nov 30, 2021

It only works with the language set to GDL-HSF.
It finds results in the same file, so can't follow a master script subroutine from a 2d script. If we solve other scripts it will be easy to allow xml source too, but in general we don't want to add new functionality for working with xml source.

@runxel
Copy link
Contributor Author

runxel commented Dec 1, 2021

Yeah I guessed so. But: Doesn't work for me (I never work with XML). Extension is uptodate.

@pbaksa
Copy link
Contributor

pbaksa commented Dec 13, 2021

Try editing the file, adding an enter, does it solve the issue?

For me a certain SCM extension loads the unmodified document in an invisible editor, which this extension handles unnecessarily. We will need to apply changes only of the active editor in GDLExtension.onDocumentChanged()

@runxel
Copy link
Contributor Author

runxel commented Dec 14, 2021

Ah, it seems that it somehow needs some kind of initialization. The trick with hitting enter worked!

pbaksa added a commit that referenced this issue Feb 14, 2023
@pbaksa
update reference guide: (#3)
9e84db2 
rename GDLManual gdlglobal IDs containing []
pbaksa added a commit that referenced this issue Feb 14, 2023
@pbaksa
update reference guide: (#3)
d0dc38c 
rename GDLManual gdlglobal IDs containing []
pbaksa added a commit that referenced this issue Feb 14, 2023
@pbaksa
# This is a combination of 11 commits.
219f762 
# This is the 1st commit message:

use constants from currently edited text

# This is the commit message #2:

search definitions in master script
search references from master in other scripts

# This is the commit message #3:

find other references from selected reference
use extra parser for subroutine calls (don't include yet in symbols)

# This is the commit message #4:

use current edited version of HSF files

# This is the commit message #5:

Show all definitions / references, even erroneous

# This is the commit message #6:

use HSFLibpart to handle other scripts of libpart
don't use extension setting for intellisense filtering

# This is the commit message #7:

Revert "use HSFLibpart to handle other scripts of libpart"

This reverts commit 32463ec.

# This is the commit message #8:

Revert "Show all definitions / references, even erroneous"

This reverts commit 1ca043e.

# This is the commit message #9:

Revert "use current edited version of HSF files"

This reverts commit 7a04743.

# This is the commit message #10:

Revert "find other references from selected reference"

This reverts commit 4721353.

# This is the commit message #11:

Revert "search definitions in master script"

This reverts commit 317be45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v25.2
Development

No branches or pull requests
2 participants
@runxel @pbaksa