Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for mentions, favoriteMessage and servers module #13

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

GOVINDDIXIT
Copy link
Owner

@GOVINDDIXIT GOVINDDIXIT commented Jul 7, 2019

This PR is specific to GSoC'19 project (Improve test automation in Rocket.Chat Android Repo)

Change Log

  • Add UI tests for the mentions module
  • Add UI test for the favorite message module
  • Add UI tests for servers module
  • Add unit tests for servers module
  • Fix naming of unit tests

Current Code coverage: 35% by Instructions 19% by branch

@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #13 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #13      +/-   ##
============================================
+ Coverage       0.45%   0.51%   +0.05%     
- Complexity        21      25       +4     
============================================
  Files            321     321              
  Lines          10456   10456              
  Branches        1821    1821              
============================================
+ Hits              48      54       +6     
+ Misses         10388   10382       -6     
  Partials          20      20
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/testConfig/Config.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...t/android/servers/presentation/ServersPresenter.kt 40% <0%> (+40%) 4% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46b9f9...034851a. Read the comment docs.

@GOVINDDIXIT GOVINDDIXIT changed the title Add tests for mentions and favoriteMessage module Add tests for mentions, favoriteMessage and servers module Jul 7, 2019
fix function naming
Copy link
Collaborator

@ear-dev ear-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all worked great! Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants