-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for createChannel and members module #11
Conversation
853b52c
to
a9a763b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #11 +/- ##
============================================
+ Coverage 0.46% 0.46% +<.01%
Complexity 21 21
============================================
Files 318 318
Lines 10292 10282 -10
Branches 1776 1773 -3
============================================
Hits 48 48
+ Misses 10224 10214 -10
Partials 20 20
Continue to review full report at Codecov.
|
@GOVINDDIXIT This looks good, and all the tests passed, so I will approve. One thing please...... It looks to me like this PR also includes all the changes in the "profile_details_tests" branch as well. Does that mean that you have created this branch off of your profile_userdetails_tests branch, instead of directly from develop? I think it better to have each PR represent just specific changes? |
Yes, actually I was needing some of the changes from profile_details_tests which are not present in develop branch. |
This PR is specific to GSoC'19 project (Improve test automation in Rocket.Chat Android Repo)
Merge After #10
Change Log
Current Code coverage: 18%