Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for createChannel and members module #11

Merged
merged 4 commits into from
Jul 2, 2019

Conversation

GOVINDDIXIT
Copy link
Owner

@GOVINDDIXIT GOVINDDIXIT commented Jun 30, 2019

This PR is specific to GSoC'19 project (Improve test automation in Rocket.Chat Android Repo)

Merge After #10

Change Log

  • Add UI test for the createChannel module
  • Add UI test for the members module

Current Code coverage: 18%

@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #11 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #11      +/-   ##
============================================
+ Coverage       0.46%   0.46%   +<.01%     
  Complexity        21      21              
============================================
  Files            318     318              
  Lines          10292   10282      -10     
  Branches        1776    1773       -3     
============================================
  Hits              48      48              
+ Misses         10224   10214      -10     
  Partials          20      20
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/testConfig/Config.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/chat/rocket/android/util/extensions/Ui.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../chat/rocket/android/webview/ui/WebViewActivity.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ndroid/authentication/ui/AuthenticationActivity.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...t/rocket/android/chatrooms/ui/ChatRoomsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...android/authentication/server/ui/ServerFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...t/rocket/android/chatroom/uimodel/UiModelMapper.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/chat/rocket/android/app/DateTimeHelper.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...android/chatroom/presentation/ChatRoomPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766a0d5...a9a763b. Read the comment docs.

@ear-dev
Copy link
Collaborator

ear-dev commented Jul 2, 2019

@GOVINDDIXIT This looks good, and all the tests passed, so I will approve. One thing please...... It looks to me like this PR also includes all the changes in the "profile_details_tests" branch as well. Does that mean that you have created this branch off of your profile_userdetails_tests branch, instead of directly from develop? I think it better to have each PR represent just specific changes?

@GOVINDDIXIT
Copy link
Owner Author

@GOVINDDIXIT This looks good, and all the tests passed, so I will approve. One thing please...... It looks to me like this PR also includes all the changes in the "profile_details_tests" branch as well. Does that mean that you have created this branch off of your profile_userdetails_tests branch, instead of directly from develop? I think it better to have each PR represent just specific changes?

Yes, actually I was needing some of the changes from profile_details_tests which are not present in develop branch.

@GOVINDDIXIT GOVINDDIXIT merged commit 5a76a75 into develop Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants