Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial smoothing algorithm in Dynsight #32

Merged
merged 27 commits into from
Sep 23, 2024

Conversation

SimoneMartino98
Copy link
Contributor

With this pull request I want to add the spatial smoothing parallelized algorithm.

In brief, this code can be useful when the user wants to average the value of a collective variable of a particle with the values of its neighboring particles, defined by a cutoff distance.

@SimoneMartino98 SimoneMartino98 marked this pull request as ready for review September 20, 2024 11:56
docs/source/data_processing.rst Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
src/dynsight/_internal/data_processing/spatial_average.py Outdated Show resolved Hide resolved
@andrewtarzia
Copy link
Contributor

Almost there, a few unresolved conversations above.

@@ -84,7 +83,7 @@ def spatialaverage(
universe:
The MDAnalysis `Universe` object containing the molecular dynamics
simulation data, including atom positions and trajectory.
array_path:
descriptor_array:
Path to the file containing the NumPy array of descriptor values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix.

@andrewtarzia andrewtarzia merged commit 1b0064a into GMPavanLab:main Sep 23, 2024
5 checks passed
@SimoneMartino98 SimoneMartino98 deleted the sp_avg branch September 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants