Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more lazy loading for smaller bundle size #4750

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add some more lazy loading for smaller bundle size #4750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a58b25
Lazy
cmdcolin Jan 7, 2025
26d5804
More lazy
cmdcolin Jan 7, 2025
c26cc74
Lazy snackbar
cmdcolin Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 14 additions & 42 deletions packages/core/ui/Snackbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import CloseIcon from '@mui/icons-material/Close'
import {
Alert,
Button,
IconButton,
Snackbar as MUISnackbar,
} from '@mui/material'
import { Suspense, lazy } from 'react'

import { observer } from 'mobx-react'

import type { AbstractSessionModel } from '../util'
import type { SnackbarMessage } from './SnackbarModel'

const SnackbarContents = lazy(() => import('./SnackbarContents'))

interface SnackbarSession extends AbstractSessionModel {
snackbarMessages: SnackbarMessage[]
popSnackbarMessage: () => void
Expand All @@ -19,42 +16,17 @@ const Snackbar = observer(function ({ session }: { session: SnackbarSession }) {
const { snackbarMessages } = session
const latestMessage = snackbarMessages.at(-1)

const handleClose = (_event: unknown, reason?: string) => {
if (reason !== 'clickaway') {
session.popSnackbarMessage()
}
}
return latestMessage ? (
<MUISnackbar
open
onClose={handleClose}
anchorOrigin={{ vertical: 'bottom', horizontal: 'center' }}
>
<Alert
onClose={handleClose}
action={
latestMessage.action ? (
<>
<Button
color="inherit"
onClick={e => {
latestMessage.action?.onClick()
handleClose(e)
}}
>
{latestMessage.action.name}
</Button>
<IconButton color="inherit" onClick={handleClose}>
<CloseIcon />
</IconButton>
</>
) : null
}
severity={latestMessage.level || 'warning'}
>
{latestMessage.message}
</Alert>
</MUISnackbar>
<Suspense fallback={null}>
<SnackbarContents
onClose={(_event, reason) => {
if (reason !== 'clickaway') {
session.popSnackbarMessage()
}
}}
contents={latestMessage}
/>
</Suspense>
) : null
})

Expand Down
50 changes: 50 additions & 0 deletions packages/core/ui/SnackbarContents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import CloseIcon from '@mui/icons-material/Close'
import {
Alert,
Button,
IconButton,
Snackbar as MUISnackbar,
} from '@mui/material'

import type { SnackbarMessage } from './SnackbarModel'

export default function SnackbarContents({
onClose,
contents,
}: {
onClose: (_event: unknown, reason?: string) => void
contents: SnackbarMessage
}) {
return (
<MUISnackbar
open
onClose={onClose}
anchorOrigin={{ vertical: 'bottom', horizontal: 'center' }}
>
<Alert
onClose={onClose}
action={
contents.action ? (
<>
<Button
color="inherit"
onClick={e => {
contents.action?.onClick()
onClose(e)
}}
>
{contents.action.name}
</Button>
<IconButton color="inherit" onClick={onClose}>
<CloseIcon />
</IconButton>
</>
) : null
}
severity={contents.level || 'warning'}
>
{contents.message}
</Alert>
</MUISnackbar>
)
}
Loading
Loading