-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to react 19 #4702
Update to react 19 #4702
Conversation
it looks like test failures are due to some issues with changes to the renderToString function. we use renderToString in the webworker this is noted as a practice that is discouraged in the react docs, however, it is also quite fundamental to some of our approaches at the same time, this approach has also led to a lot of trouble with hydration mismatches, node.removeChild errors, and more. it could be that we rethink the approach of trying to use true "react server side rendering" on the web worker |
note that the motivation, aside from staying up to date, is that currently e.g. embedded users or anyone cannot even use react 19 at all due to our importing of older React api's "hydrate/render" vs "hydrateRoot/createRoot", the older api's were removed in react 19 |
fd320f5
to
fba6860
Compare
Lints Stillg More bumps Add messagechannel polyfill for jest MessageChannel polyfill Misc Main thread Testing react 19 Misc Fix tsc error on jest config
6c406fc
to
6e0f9d3
Compare
Update to the newly released react 19
This would likely require a major version bump, which applies particularly to embedded users because we would no longer be compatible with react 17 or older
if we wanted to consider doing more breaking stuff, the removal of buffer could be combined with that major version bump