Add configuration of transcriptTypes and containerTypes to the svg feature rendering #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cmdcolin
force-pushed
the
container_types
branch
from
63543b7 to
d4d4e7d
Compare
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
it creates the notion of explicit "containerTypes" which create multi-row feature rendering, like the gene glyph. it also makes configurable the notion of "transcriptTypes" which was hardcoded to "transcript","primary_transcript", and "mRNA".
Background
This PR helps address concerns in #4599
The issue brought up previous relied on what was basically a bug to allow a GFF with a parent feature with children to be rendered as multiple rows in the output
This multi-row rendering is pretty specialized to "gene" style rendering but worked well for their case
Therefore, this PR proposes "containerTypes" (which render as multiple rows, like the gene glyph) and then also "transcriptTypes" which corresponds with ProcessedTranscript types.
Footnote
It would be good to allow clicking the subrows of these containerTypes (e.g. for a normal gene glyph, click an individual transcript) but that is still an ongoing todo.