Fix navigating to a refname result that is also indexed in search track index #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you query the search box for a refname, you can get a situation where manually clicking on the returned search results does nothing
This PR fixes that
Fixes #4452
Note: i'm not even attempting to document the exact data flow and reason why this PR fixes the issue at this time. This is a bit of a stop gap solution. The behavior of the search box is complex and i admittedly do not actually know the exact sequence of steps that leads to this scenario happening, a more thorough analysis could be useful, as well as for potentially refactoring the data flow of the search box