Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening .jbrowse files on desktop #4590

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix opening .jbrowse files on desktop #4590

merged 1 commit into from
Sep 25, 2024

Conversation

cmdcolin
Copy link
Collaborator

Electron made it so file choosers can't get a .path property from a File object in recent versions

Instead you have to call "electron.webUtils.getPathForFile(arg:File)"

@cmdcolin cmdcolin force-pushed the fix_desktop_fileopen branch 2 times, most recently from b1f80f9 to 80dc614 Compare September 25, 2024 15:07
@cmdcolin cmdcolin merged commit 8d49fdd into main Sep 25, 2024
0 of 4 checks passed
@cmdcolin cmdcolin deleted the fix_desktop_fileopen branch September 25, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant