Fix performance regression since v2.14.0 in assembly loading #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.14.0 introduced the NCBI sequence report adapter (xref https://github.com/GMOD/jbrowse-components/pull/4516/files) which allows e.g. NC_000001.11 to be displayed as chr1 in the UI)
Unfortunately there was an unexpected performance regression, due to accessing a mst observable outside of an observable context, causing it to be re-calculated for every invocation which was once per refname so it was a big slowdown
can see that loading a human FASTA takes:
before, 8000milliseconds (8s):
after, 10ms:
