Fix cascading sub menus bug in embedded components in v2.14.0 #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded-core ViewMenu (e.g. where there are view level options like Export SVG) ended up diverging slightly from the app-core ViewMenu, where it did not use CascadingMenu, and then a bug introduced during refactoring (removal of Grow component from the @jbrowse/core/ui/Menu) resulted in the cascading effect not working, instead putting all cascading menus on the screen at once
screenshot
This fixes it by both
a) Adding the Grow back to @jbrowse/core/ui/Menu
b) Converting the embedded-core ViewMenu to use CascadingMenu, just because there are benefits to the CascadingMenu (it avoids offscreen behavior)