Fix alignments track feature details customization #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
changed the title
cmdcolin
changed the title
cmdcolin
force-pushed
the
fix_alignments_customization
branch
3 times, most recently
from
90e24fb to
2fd4e1f
Compare
cmdcolin
force-pushed
the
fix_alignments_customization
branch
from
2fd4e1f to
c4b60ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #4540
The addition of the "track handle" to the feature widget model helps so the feature details can get the featureDetails callback e.g. getConf(track, 'featureDetails',...)
However, on main, the track handle is only added when it is a "BaseFeatureDetails" widget in the BaseLinearDisplayModel::selectFeature function, and not for the AlignmentTrack and SyntenyTrack "AlignmentsFeatureDetails" widget
This PR fixes that :)