Store and retrieve user track selector settings in local storage #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
localstorage_track_settings
branch
from
0dbb71e to
1f8451e
Compare
|
I now changed the settings to volatiles instead of model state to avoid the situation where e.g. "loading another users session" would overwrite all your "collapsed preferences" |
cmdcolin
force-pushed
the
localstorage_track_settings
branch
2 times, most recently
from
d8a53ae to
c7e1386
Compare
cmdcolin
force-pushed
the
localstorage_track_settings
branch
from
dc9bdc6 to
b9e54b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3977
Currently if you collapse a category in the track selector, then close it, then re-open it, then is not collapsed on re-opening.
This stores the collapsed category settings and sort settings in localStorage