-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow moving tracks and views up/down/to top/to bottom, and better click and drag track re-ordering #4337
Conversation
other options could include making these up/down options on the track label themselves |
fixes #4315 |
small bonus: by avoiding getSnapshot in the "moveTrack" function (used for click and drag to re-order tracks in the lgv) it avoids the tracks having to re-render themselves |
ed55e53
to
a69e73d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested -- looks and feels good
I feel like "options" isn't the best word for this menu item. Google slides for example uses the word "Order" in their options for moving items to the front/back.
Probably best in another PR but I feel like the click+drag functionality should be updated to be more in line with how intuitive + fluid this feels.
agree on the wording being tricky...order is good though! |
805035f
to
041fa67
Compare
also interestingly, I think the "dimming" of the tracks does not work and was piling up the dimming at the top of the view instead of being dimmed at the right y-offset. removing the dimming may help |
041fa67
to
df5bb29
Compare
i've removed the dimming to try to help with that situation for now |
this is supplementary to pinning track, I think there is still an opportunity to have these operations without track pinning
see screenshot, since it expands the number of menu items significantly the options are placed under a submenu sort of opaquely named "options"