Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moving tracks and views up/down/to top/to bottom, and better click and drag track re-ordering #4337

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

cmdcolin
Copy link
Collaborator

this is supplementary to pinning track, I think there is still an opportunity to have these operations without track pinning

see screenshot, since it expands the number of menu items significantly the options are placed under a submenu sort of opaquely named "options"

Screenshot 2024-04-11 at 9 42 35 PM

@cmdcolin
Copy link
Collaborator Author

other options could include making these up/down options on the track label themselves

@cmdcolin
Copy link
Collaborator Author

fixes #4315

@cmdcolin
Copy link
Collaborator Author

small bonus: by avoiding getSnapshot in the "moveTrack" function (used for click and drag to re-order tracks in the lgv) it avoids the tracks having to re-render themselves

@cmdcolin cmdcolin force-pushed the move_track_ops branch 2 times, most recently from ed55e53 to a69e73d Compare April 12, 2024 03:10
Copy link
Contributor

@carolinebridge carolinebridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested -- looks and feels good

I feel like "options" isn't the best word for this menu item. Google slides for example uses the word "Order" in their options for moving items to the front/back.

Probably best in another PR but I feel like the click+drag functionality should be updated to be more in line with how intuitive + fluid this feels.

@cmdcolin
Copy link
Collaborator Author

agree on the wording being tricky...order is good though!

@cmdcolin
Copy link
Collaborator Author

also interestingly, I think the "dimming" of the tracks does not work and was piling up the dimming at the top of the view instead of being dimmed at the right y-offset. removing the dimming may help

@cmdcolin
Copy link
Collaborator Author

i've removed the dimming to try to help with that situation for now

@cmdcolin cmdcolin merged commit 2ca3291 into main Apr 12, 2024
10 checks passed
@cmdcolin cmdcolin changed the title Add track menu items to move track to up/down/to top/to bottom, and moving views to top/to bottom Allow moving tracks and views up/down/to top/to bottom, and better click and drag track re-ordering Apr 12, 2024
@cmdcolin cmdcolin deleted the move_track_ops branch April 12, 2024 15:52
@cmdcolin cmdcolin added the enhancement New feature or request label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants