Add retry method to share link dialog in case of error

[cmdcolin]

example screenshot of new error box with the refresh icon

changes the text "Show stack trace" to the "Report" icon, and optionally displays a refresh icon if a "onReset" callback is passed to ErrorMessage

fixes #4274

[cmdcolin]

this is a bonus optimization. if the stack trace goes through 20 stack frames of mobx-state-tree function calls, then it was reparsing the stack trace 20 times which added up to 5 seconds of waiting for the stack trace. this parses it just once

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 62.57%. Comparing base (67d5877) to head (3e6519a).
Report is 2 commits behind head on main.

Files	Patch %	Lines
packages/core/ui/ErrorMessageStackTraceDialog.tsx	0.00%	18 Missing ⚠️
packages/core/ui/ErrorMessage.tsx	66.66%	2 Missing and 1 partial ⚠️
...roducts/jbrowse-web/src/components/ShareDialog.tsx	75.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4276      +/-   ##
==========================================
- Coverage   62.60%   62.57%   -0.03%     
==========================================
  Files        1087     1087              
  Lines       31404    31416      +12     
  Branches     7497     7499       +2     
==========================================
  Hits        19659    19659              
- Misses      11572    11581       +9     
- Partials      173      176       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[carolinebridge]

Bit jarring how the ui "disappears" when you view the stack trace, I think I'd like to see the stack trace inline with the rest of the modal. At a minimum, provide the user the retry button so they don't have to close + reopen.

-- also, when there's a failure to fetch copy to clipboard copies nothing, but provides a success message. Maybe disable it until there's something ready to copy?

[cmdcolin]

Bit jarring how the ui "disappears" when you view the stack trace, I think I'd like to see the stack trace inline with the rest of the modal. At a minimum, provide the user the retry button so they don't have to close + reopen.

not sure i understand, do you have a screen recording? note that chunk loading errors are a particular case of this that may be tricky to add retry functionality for #3523

[carolinebridge]

not sure i understand, do you have a screen recording? note that chunk loading errors are a particular case of this that may be tricky to add retry functionality for #3523

You can see it in the screenshot -- the button options to bookmark, copy, close disappear

[cmdcolin]

gotcha. possibly adding another "ErrorBoundary" could catch it but i'm not sure where. the error boundary you are seeing in that screenshot is likely this one

jbrowse-components/packages/core/ui/Dialog.tsx

Lines 71 to 88 in 3e6519a

	<ErrorBoundary FallbackComponent={DialogError}>
	<ThemeProvider
	theme={createTheme(theme, {
	components: {
	MuiInputBase: {
	styleOverrides: {
	input: {
	// xref https://github.com/GMOD/jbrowse-components/pull/3666
	boxSizing: 'content-box!important' as 'content-box',
	},
	},
	},
	},
	})}
	>
	{children}
	</ThemeProvider>
	</ErrorBoundary>