Fix subfeature refNames on BED and BEDTabix parsers #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
fix_bed_refname
branch
from
1ebb8f9 to
206d269
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4158 +/- ##
=======================================
Coverage 63.03% 63.04%
=======================================
Files 1067 1067
Lines 31101 31102 +1
Branches 7428 7428
=======================================
+ Hits 19605 19608 +3
+ Misses 11327 11323 -4
- Partials 169 171 +2 ☔ View full report in Codecov by Sentry. |
cmdcolin
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a refName field to all subfeatures.
Fixes #4156
An alternative could potentially be done so that the subfeatures always look at their parent feature for the refName but this is interim or easy fix