Add support for single file hubs #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
force-pushed
the
singlefilehub2
branch
from
cb9364a to
d9a6177
Compare
cmdcolin
added
enhancement
github-actions
bot
added
the
needs label triage
|
currently uses sessionAssemblies to load the assembly from the trackhub, but could potentially use a new type of object e.g. connectionAssemblies also |
cmdcolin
removed
the
needs label triage
cmdcolin
force-pushed
the
singlefilehub2
branch
2 times, most recently
from
6f1f83f to
3d65f31
Compare
cmdcolin
force-pushed
the
singlefilehub2
branch
2 times, most recently
from
c92648b to
2d799d2
Compare
cmdcolin
force-pushed
the
singlefilehub2
branch
from
2d799d2 to
992b059
Compare
cmdcolin
force-pushed
the
singlefilehub2
branch
from
ed8cbd7 to
f4a8e1e
Compare
cmdcolin
force-pushed
the
singlefilehub2
branch
from
be7e6e6 to
db920a1
Compare
cmdcolin
force-pushed
the
singlefilehub2
branch
from
db920a1 to
b0136f1
Compare
|
I think this PR will go forward with adding connection assemblies as sessionAssemblies. it could be that in the future we change it to use a specialized connectionAssemblies concept. |
|
there are a number of other UI and workflow improvements needed around this e.g. just opening up a singlefile hub for some random genome should probably say "ok! launch a lgv of it now" because it is basically just silently added to the importform currently. other things that would be good include adding a URL param |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3627
Fixes #3461
Fixes #1444
It uses this branch of @gmod/ucsc-hub GMOD/ucsc-hub-js#37 which refactors the SingleFileHub support (in a number of ways, but notably to only use a single TrackDbFile object for the tracks instead of an array of TrackFileDb objects for the tracks which was sort of difficult to work with)