Add arc plugin to @jbrowse/react-linear-genome-view core plugins #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
|
Can see crash here https://jbrowse.org/storybook/lgv/main/?path=/docs/getting-started--docs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4067 +/- ##
=======================================
Coverage 63.19% 63.19%
=======================================
Files 1044 1044
Lines 30551 30551
Branches 7289 7289
=======================================
Hits 19307 19307
Misses 11073 11073
Partials 171 171 ☔ View full report in Codecov by Sentry. |
cmdcolin
added
enhancement
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lgv storybook actually crashes because the volvox config added a sample track that is a LinearPairedArcDisplay, which is supplied by plugin-arc, which works in jbrowse-web but not in the @jbrowse/react-linear-genome-view because plugin-arc is not added to the react-linear-genome-view
We could filter this out but IMO its probably just better to add this arc plugin to the lgv. It has useful variant viewing characteristics for SVs which embedded can use