Fix missing icons on some cascading menus #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4059 +/- ##
==========================================
- Coverage 63.20% 63.17% -0.04%
==========================================
Files 1044 1044
Lines 30548 30551 +3
Branches 7285 7288 +3
==========================================
- Hits 19309 19300 -9
- Misses 11068 11082 +14
+ Partials 171 169 -2 ☔ View full report in Codecov by Sentry. |
|
do you have a screenshot showing what you mean? the track menu uses CascadingMenuButton but it has icons |
|
before: after: |
|
oh gotcha, that makes sense. probably was lost in translation to the 'cascading style', good catch |
|
random thing: looks like this makes the 'display types' menu option go out of alignment in some cases
|
cmdcolin
force-pushed
the
fix-broken-icons
branch
from
e91b3a6 to
689c8a1
Compare
cmdcolin
changed the title
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that cascading menus were missing icons even when they were supplied to the list of MenuItems.
Not sure if the code changes align with the original intent of the component (e.g. I couldn't figure out why 'inset' was being used and the icon wasn't instead?), but this PR adds the provided icons to a cascading menu back to the left side of the menu text.