Fix browser back button behavior in jbrowse-web #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
changed the title
cmdcolin
added
bug
|
note that the linked issue mentions linking 'browser back button' to actual in-app 'undo/redo' functionality, but this PR is a little unrelated: the current 'browser back button' behavior was more effectively a do-nothing because it was filled by various 'garbage pushState updates' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL manipulations we do in jbrowse-web are based on URL query params, but the default of the query param manipulation effectively used "pushState" (https://developer.mozilla.org/en-US/docs/Web/API/History/pushState) instead of "replaceState" (https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState)
this was managed by the library we used (use-query-params), but this PR changes it to use replace instead now. This allows the browser back button to work more intuitively I think now
Fixes #1128