Spreadsheet view refactor to use @mui/x-data-grid component and volatile storage #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
|
possible alternative: leave the existing spreadsheet view as-is to avoid any breaking behavior, and make this a new view type, however, then we have two things for ongoing maintenance |
|
small bonus endeavor: adding #788 splitting out VCF INFO column into multiple filterable/sortable columns screenshot shows this |
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
e0710f6 to
e09e5c9
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
83c55ee to
f7dd8e3
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
8e1da47 to
7f7c6f8
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
7f7c6f8 to
6543aba
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
6543aba to
faee91c
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
dd4d2f9 to
dbe6b86
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
66f78f6 to
cae4f0e
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
cae4f0e to
ebc2e25
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
ebc2e25 to
3c1af1b
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
37c4db4 to
afba15a
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
afba15a to
6f77f35
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
d56f7f1 to
5a0b3f7
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
5a0b3f7 to
075ed05
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
075ed05 to
834ad10
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
834ad10 to
97f3960
Compare
Remove [skip ci] Volatile [skip ci] Parse out INFO field [skip ci] Misc Misc Restyling Refactoring More misc Misc Misc Misc Misc New Refname renaming fix for breakpoint split view Breakpoint split view Misc [skip ci] Refactors Use 7.0.0 Updates Misc Misc Misc SV inspector working Wow Misc More notifyError
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
97f3960 to
5d5aa6f
Compare
|
replaced by #4682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the spreadsheet view stores all data in the mobx-state-tree. This has a small convenience, but it lags very strongly for any reasonably sized data file loaded into it. A 33Mb VCF takes slows down a lot, taking up a lot of memory (which is a known issue mobxjs/mobx-state-tree#1683). This PR changes to loading directly from a volatile. With this PR, it loads the 33Mb VCF almost very fast, and takes up much less memory
There will require work to make this attain feature parity with existing spreadsheet view, but I believe it will be a valuable change