Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to horizontally flip view when launching linear synteny view on inverted feature #4035

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 2, 2023

The text description of this text box is a little lengthy, but I think it helps clarify the behavior. Currently, it automatically horizontally flips the lower panel if an inverted feature is used to launch the linear synteny view, but this instead prompts the user for this behavior. The checkbox is not shown at all if the feature is not inverted, but the window size is still prompted (which kind of is just a small thing to justify showing a dialog box)

inverted feature

image

non inverted feature

image

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 2, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #4035 (c07f1eb) into main (4fe46f8) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 1.17%.

❗ Current head c07f1eb differs from pull request most recent head 9d30d7d. Consider uploading reports for the commit 9d30d7d to get more accurate results

@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
- Coverage   63.68%   63.64%   -0.04%     
==========================================
  Files        1026     1028       +2     
  Lines       30251    30276      +25     
  Branches     7199     7203       +4     
==========================================
+ Hits        19264    19270       +6     
- Misses      10822    10840      +18     
- Partials      165      166       +1     
Files Coverage Δ
...core/BaseFeatureWidget/BaseFeatureDetail/index.tsx 76.66% <0.00%> (-1.30%) ⬇️
...ar-comparative-view/src/LGVSyntenyDisplay/model.ts 73.07% <25.00%> (+49.90%) ⬆️
...tenyDisplay/components/LaunchSyntenyViewDialog.tsx 0.00% <0.00%> (ø)
...tive-view/src/LGVSyntenyDisplay/components/util.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cmdcolin cmdcolin force-pushed the ask_horizontally_flip branch from c07f1eb to 9d30d7d Compare November 3, 2023 01:13
@cmdcolin cmdcolin merged commit 716aac0 into main Nov 3, 2023
@cmdcolin cmdcolin deleted the ask_horizontally_flip branch November 3, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant