Remove type any from return value of getContainingView, getSession
#3959
Conversation
github-actions
bot
added
the
needs label triage
|
I also tried to move towards using focusedViewId rather than focusedView in some places This PR originally was started because embedded code was calling setFocusedViewId when selecting a feature, but this was a crash on embedded Technically embedded should probably say it is 'always focused' to enable embedded to have keyboard shortcuts but thats not done here yet |
cmdcolin
removed
the
needs label triage
| /** | ||
| * #action | ||
| */ | ||
| activateConfigurationUI() { |
There was a problem hiding this comment.
appeared unused, I think the behavior is wrong also (getting return value of editTrackConfiguration and then hiding/showing...)
| @@ -1141,6 +1141,7 @@ export function getTickDisplayStr(totalBp: number, bpPerPx: number) { | |||
| } | |||
|
|
|||
| export function getViewParams(model: IAnyStateTreeNode, exportSVG?: boolean) { | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
should probably move to @jbrowse/plugin-linear-genome-view
| isSessionModelWithWidgets(session) | ||
| ) { | ||
| confs.forEach(c => session.addTrackConf(c)) | ||
| confs.forEach(c => model.view.showTrack(c.trackId)) |
There was a problem hiding this comment.
there was a bug here where I think it wanted to showTrack(c.trackId) but instead it was just forEach c=>c.trackId
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
Currently the objects returned by getSession, getContainingView, and others are essentially type
anybecause they are e.g. an AbstractSessionModel & IAnyStateTreeModelBy mixing (&'ing) with IAnyStateTreeModel, the whole thing is
anyThis removes the & IAnyStateTreeModel, and then cleans up some usage of these functions in the code including type guards, adding more stuff to the abstract model, etc.