Add jobs widget to jbrowse-web #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 63.75% 63.76% +0.01%
==========================================
Files 1018 1018
Lines 30164 30172 +8
Branches 7189 7192 +3
==========================================
+ Hits 19230 19239 +9
+ Misses 10770 10767 -3
- Partials 164 166 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carolinebridge
removed
the
needs label triage
cmdcolin
reviewed
Oct 2, 2023
| @@ -40,6 +40,7 @@ export default class extends Plugin { | |||
| let jobStatusWidget = widgets.get('JobsList') | |||
| if (!jobStatusWidget) { | |||
| jobStatusWidget = session.addWidget('JobsListWidget', 'JobsList') | |||
| session.showWidget(jobStatusWidget) | |||
There was a problem hiding this comment.
nit: showWidget is on both sides of the if/else, can probably move outside of if/else
cmdcolin
reviewed
Oct 2, 2023
| @@ -11,6 +11,12 @@ const JobCard = observer(function JobCard({ job }: { job: NewJob }) { | |||
| <strong>{'Name: '}</strong> | |||
| {job.name} | |||
| </Typography> | |||
| {job.statusMessage ? ( | |||
| <Typography variant="body1"> | |||
| <strong>{'Message: '}</strong> | |||
There was a problem hiding this comment.
nit: don't have to use the curly for the plain-old-string on the strong line of the jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accommodates Apollo #234
summary of changes