Use shortened VCF feature description for some types of insertions and deletions #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
removed
the
needs label triage
cmdcolin
commented
Sep 7, 2023
| @@ -115,7 +115,7 @@ export function getSOAndDescByExamination(ref: string, alt: string) { | |||
| } else if (alt === '<DEL>') { | |||
| return ['deletion', alt] | |||
| } else if (alt === '<INV>') { | |||
| return ['deletion', alt] | |||
| return ['inversion', alt] | |||
There was a problem hiding this comment.
this was also incorrectly saying type features were deletions, which would show up on feature.get('type'). subtle but needing a fix :)
|
fixes #3892 |
cmdcolin
force-pushed
the
cleanup_indel_vcffeature_description
branch
from
653bc07 to
e870730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HG002 SV benchmark VCF has a particular way of describing insertions and deletions where it exactly specifies the deletion and insertion sequence in REF and ALT fields, even when these are quite long.
The resulting description strings generated on the VCF track are kind of unreadable as a result. This PR makes it so that insertions and deletions longer than 5bp are turned into just a string saying e.g. "10bp DEL" or "10bp INS"
current main
this branch
