Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only have focus if multiple views #3862

Closed
wants to merge 1 commit into from

Conversation

garrettjstevens
Copy link
Collaborator

@garrettjstevens garrettjstevens self-assigned this Aug 16, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 16, 2023
@carolinebridge
Copy link
Contributor

This feels pretty good imo -- the context when you add a new view and click around (thus enabling the light/dark relationship) feels like enough to communicate the concept of focus to the user.

@cmdcolin
Copy link
Collaborator

another way to make it more abundantly clear which is active is to put e.g. "(active)" in the title bar if there are multiple views

I almost think making the color hint subtler and adding that could be useful. alternatively the border concept could be reconsidered but i'd just try to avoid something like a yellow border as it is a little bold...just a subtle border i think would be nice. as i'm typing in this textfield for example, there is a little blue border that turns greay when i click away

@cmdcolin
Copy link
Collaborator

I would not make it so that the focusedView getter returns undefined if there is only one view, because focusedView can be used for other purposes (keyboard shortcuts)

@cmdcolin
Copy link
Collaborator

Whether we want the color to change only when there are multiple views, or to return the actual view instead of the id, may be separate issues. I think id is not bad as it is easier to convert to a persistent model attribute

@cmdcolin
Copy link
Collaborator

as mentioned in my above comments, this approach will likely be unused. I will vote for close (sorry, just trying to close out old PRs). we can re-visit if this is of interest still in a new pr

@cmdcolin cmdcolin closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants