Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where multi-quantitative tracks plotted incorrectly for some bigwigs with empty regions #3839

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Aug 9, 2023

Fixes #3838

The key is that I assumed that all subtracks would return some feature for splitting into groups and getting a reliable number of "groups" but instead we can use the "sources" variable that is passed as a prop

(Sources is something that the display passes to the renderer, and the display itself requests the "sources" of the multiquantitative track as a separate RPC call. just for interest, the number of subtracks could change regionally in this way)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 9, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 9, 2023
@cmdcolin cmdcolin force-pushed the fix_multiwig_empty_regions branch from 48707a3 to 8a5da11 Compare August 9, 2023 15:08
@cmdcolin cmdcolin force-pushed the fix_multiwig_empty_regions branch from 8a5da11 to 168cc7e Compare August 9, 2023 16:02
@cmdcolin cmdcolin changed the title Fix bug where multiquantitativetracks plotted incorrectly for some bigwigs with empty regions Fix bug where multi-quantitative tracks plotted incorrectly for some bigwigs with empty regions Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3839 (168cc7e) into main (1c43657) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
+ Coverage   64.39%   64.40%   +0.01%     
==========================================
  Files         999      999              
  Lines       29710    29710              
  Branches     7125     7125              
==========================================
+ Hits        19133    19136       +3     
+ Misses      10415    10412       -3     
  Partials      162      162              
Files Changed Coverage Δ
...e/src/MultiDensityRenderer/MultiDensityRenderer.ts 0.00% <0.00%> (ø)
...e/src/MultiRowLineRenderer/MultiRowLineRenderer.ts 0.00% <0.00%> (ø)
...c/MultiRowXYPlotRenderer/MultiRowXYPlotRenderer.ts 95.83% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 6f1fa62 into main Aug 9, 2023
@cmdcolin cmdcolin deleted the fix_multiwig_empty_regions branch August 9, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi-wiggle track rendering issue
1 participant