Allow workers to load CJS plugins #3796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3785
Worked on this with @cmdcolin during our pairing yesterday, and since then I've created a CJS plugin to test with that does node-native module import on the worker.
Because our electron version now uses node 18, we can use
fetch
natively. Also because webpack 5 doesn't do any polyfilling, we can avoid a bunch ofwindow.require
s that were a workaround to avoid the polyfilling.