Fix synteny rubberband tooltips when views are exactly the same #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #3784 +/- ##
==========================================
- Coverage 64.24% 64.24% -0.01%
==========================================
Files 987 988 +1
Lines 29671 29678 +7
Branches 7096 7098 +2
==========================================
+ Hits 19063 19066 +3
- Misses 10444 10447 +3
- Partials 164 165 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
added
bug
cmdcolin
force-pushed
the
synteny_rubberband_tooltips
branch
from
2ee82a2 to
487c201
Compare
cmdcolin
force-pushed
the
synteny_rubberband_tooltips
branch
from
487c201 to
544cee3
Compare
|
removed the row 1/row 2 text...just infer from context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the synteny view is showing volvox vs volvox at the exact same positions (which can happen if you open a synteny view and select the default choice of volvox vs volvox for example)
This is a picture of the bug, which is due to colliding React keys on the tooltips
This additionally modifies the tooltips to make it more clear what the text represents by specifying the assembly name and "row number"