-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use inlineSourceMaps for tsc builds and other misc changes #3771
Conversation
cmdcolin
commented
Jun 28, 2023
- Changes sourceMap->inlineSourceMap in tsconfig, and remove 'src' directory from package.json files
- Centralizes a couple tsconfig options instead of redeclaring them in every file
- Renames "es5" to "commonjs" since this is a better descriptor of what the dist build actually is
- Uses symlinks for all plugin tsconfigs. I tried also referring to the tsconfigs at a relative path but that is a bit tricky
Codecov Report
@@ Coverage Diff @@
## main #3771 +/- ##
==========================================
- Coverage 64.11% 64.10% -0.02%
==========================================
Files 987 987
Lines 29663 29663
Branches 7094 7094
==========================================
- Hits 19018 19015 -3
- Misses 10481 10484 +3
Partials 164 164 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It actually occurred to me that this will eliminate the ability to 'import from the src' directory which the bbimber lab is currently doing BimberLab/DiscvrLabKeyModules#205 I think it is not necessarily a supported workflow that they have though so we may want to work with them to find a work-around |
I tested this against https://github.com/joneubank/minimal-reproduce-jbrowse-component-build by copying the "packed" resolutions similar to our component_tests and it appeared to fix the issue that was seen there |
just realized that using inlineSourceMap does not suffice for removing src directory, the inlineSourceMap will still refer to a src directory. the alternative is just not having src maps. might not be too bad that way...our code isn't extensively mangled by the compilation |
(the source map, whether inline or external .map file, just map stores offsets in built artifacts still with the src directory it came from) |