Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render alignment track arcs instantly after bpPerPx change #3700

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

#3697 reintroduced the render delay for the non block based arc tracks, which only renders after a certain timeout instead of on every frame, but this PR adds code to instantly render after a zoom level change, instead of after a render delay, which helps avoid "blanking" (a new vocab word) of the screen

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 11, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 11, 2023
@cmdcolin cmdcolin changed the title Render arcs instantly after bpPerPx change Render alignment track arcs instantly after bpPerPx change May 11, 2023
@cmdcolin cmdcolin force-pushed the ric_arcs branch 2 times, most recently from f81e136 to f168266 Compare May 11, 2023 17:28
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3700 (efa5bd2) into main (7a95722) will increase coverage by 0.01%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
+ Coverage   64.00%   64.01%   +0.01%     
==========================================
  Files         924      925       +1     
  Lines       29982    29989       +7     
  Branches     7274     7275       +1     
==========================================
+ Hits        19190    19198       +8     
+ Misses      10609    10608       -1     
  Partials      183      183              
Impacted Files Coverage Δ
.../alignments/src/LinearReadArcsDisplay/drawFeats.ts 77.27% <ø> (-1.30%) ⬇️
...alignments/src/LinearReadCloudDisplay/drawFeats.ts 85.55% <ø> (-1.26%) ⬇️
plugins/alignments/src/shared/renderSvg.tsx 0.00% <0.00%> (ø)
...s/linear-genome-view/src/LinearGenomeView/model.ts 84.48% <ø> (ø)
...ins/alignments/src/LinearReadArcsDisplay/model.tsx 48.43% <71.42%> (-5.62%) ⬇️
...ns/alignments/src/LinearReadCloudDisplay/model.tsx 60.46% <75.00%> (-0.32%) ⬇️
.../alignments/src/shared/dynamicTrackAfterAttach.tsx 96.29% <96.29%> (ø)
...inearReadArcsDisplay/components/ReactComponent.tsx 100.00% <100.00%> (ø)
...ins/alignments/src/shared/BaseDisplayComponent.tsx 90.90% <100.00%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 4dc7fa2 into main May 11, 2023
@cmdcolin cmdcolin deleted the ric_arcs branch May 11, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant