Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against undefined in CoreGetFeatureDetails #3681

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 4, 2023

Fixes #3674

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 4, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 4, 2023
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented May 4, 2023

could consider the entire 'soundness' of this operation perhaps as a separate issue, but this should avoid some crashes (that were observed under load by @carolinebridge-oicr )

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #3681 (23c4584) into main (ba81be7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
+ Coverage   62.62%   62.64%   +0.01%     
==========================================
  Files         892      892              
  Lines       30252    30249       -3     
  Branches     7321     7321              
==========================================
+ Hits        18946    18948       +2     
+ Misses      11123    11118       -5     
  Partials      183      183              
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 66.25% <ø> (ø)
packages/core/rpc/methods/CoreGetFeatureDetails.ts 77.77% <100.00%> (-3.18%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 114bcda into main May 4, 2023
@cmdcolin cmdcolin deleted the core_get_guard branch May 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guard against undefineds in CoreGetFeatureDetails
1 participant