-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to highlight regions with click and drag rubberband #3648
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3648 +/- ##
==========================================
- Coverage 63.07% 63.03% -0.04%
==========================================
Files 877 878 +1
Lines 30168 30193 +25
Branches 7276 7279 +3
==========================================
+ Hits 19027 19031 +4
- Misses 10956 10977 +21
Partials 185 185
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Might be cool to add the ability to highlight your bookmarks in different colours / bulk highlight your bookmarks. I uncovered a little bit of a bug I can recreate with some trial and error (though it did happen the first time I was messing around with this functionality):
It's pretty minor, refreshing removes it, so might not be a super big concern. Here's a mov of what it looks like: highlight_bug.mov |
Could also consider changing the order of the options around; for some reason I keep clearing all (impulse clicking the first option) when I mean to add to my existing highlights...something like:
|
the highlight getting stuck was fixed in ca35e78 (needed to use array index to fully deduplicate the highlight keys) |
as long as we are talking about all the ways to get highlights, as there are many...getting highlights from e.g. an adapter like a bed could be useful...was done in jbrowse 1 with the concept of 'bookmarks' which were similar to highlights https://jbrowse.org/docs/url_strings.html#addbookmarks |
may try to deliver this type of highlight system as a 'plugin' that incorporates extension points to e.g. extend the lgv model and use #3663 |
from discussion at weekly ^^ |
probably will close for now, will not be merging as is |
This let's a user click and drag using the rubberband bar a region to highlight one or more regions (by either "Set only this highlight" and "Add to existing highlights")