Add authorization(internetAccount) support for Trix index files #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount to make authorization work for Trix index files.
github-actions
bot
added
the
needs label triage
|
looks like a shoe-in! thanks for adding this :) |
cmdcolin
removed
the
needs label triage
|
I know I at one point grepped the codebase for instances of openLocation that were missing pluginManager but must have missed this |
|
remaining codebase instances of openLocation without auth appear to be in our jbrowse 1 and ucsc connections |
cmdcolin
changed the title
cmdcolin
pushed a commit
that referenced
this pull request
May 18, 2023
Use pluginManager in TrixTextSearchAdapter to enable use of internetAccount to make authorization work for Trix index files. Co-authored-by: grzelaka <andrzej.grzelak@contractors.roche.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trix files were the only files that ignored "intenetAccountId" and thus did not use authorization. This commit enables existing support for them.