Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to open refNameAliases+cytobands in "Open sequence" start screen on desktop #3513

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 9, 2023

They are behind a button called "Show advanced" options, so re hidden by default. Fixes #3499

Screenshot from 2023-02-09 11-19-59

Screenshot from 2023-02-09 11-20-34

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 9, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 9, 2023
@cmdcolin cmdcolin force-pushed the refnamealias_input_desktop branch from 585c33f to c3a195c Compare February 15, 2023 21:10
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3513 (c3a195c) into main (f4b651e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head c3a195c differs from pull request most recent head 93ceae9. Consider uploading reports for the commit 93ceae9 to get more accurate results

@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
- Coverage   62.60%   62.57%   -0.03%     
==========================================
  Files         859      860       +1     
  Lines       30139    30153      +14     
  Branches     7222     7232      +10     
==========================================
  Hits        18869    18869              
- Misses      11082    11096      +14     
  Partials      188      188              
Impacted Files Coverage Δ
packages/core/ui/theme.ts 73.23% <ø> (ø)
products/jbrowse-desktop/src/AdapterInput.tsx 0.00% <0.00%> (ø)
...roducts/jbrowse-desktop/src/OpenSequenceDialog.tsx 3.77% <0.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

adds a couple rider changes

  • passing pluginManager to openLocation on refnamealias/cytoband adapters, needed for auth scenarios using assemblies
  • support gzip files in cytoband adapter

@cmdcolin
Copy link
Collaborator Author

smaller togglebuttongroup via theme also

@cmdcolin cmdcolin merged commit 239207d into main Feb 15, 2023
@cmdcolin cmdcolin deleted the refnamealias_input_desktop branch February 15, 2023 22:01
@cmdcolin cmdcolin changed the title Add ability to specify refNameAliases and cytobands in "Open sequence" start screen for desktop Add ability to open refNameAliases+cytobands in "Open sequence" start screen on desktop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to more easily open refNameAliases on desktop
1 participant