-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Show all regions" for dotplot and synteny views and refactor synteny rendering RPC to optimize scrolling #3440
Conversation
88af1bb
to
175deab
Compare
175deab
to
0963bea
Compare
Codecov Report
@@ Coverage Diff @@
## main #3440 +/- ##
==========================================
- Coverage 61.50% 61.28% -0.22%
==========================================
Files 821 818 -3
Lines 29448 29529 +81
Branches 7072 7065 -7
==========================================
- Hits 18113 18098 -15
- Misses 11172 11262 +90
- Partials 163 169 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
416e3db
to
2b3b0e4
Compare
This PR now combines #3442 and #3441 the result is that the "LinearSyntenyRenderer" concept is removed, instead doing all drawing in the LinearSyntenyDisplay (inside an autorun, similar to the LinearAlignmentArcsDisplay) the difference in performance is not "super significantly improved", but is maybe 2x faster, with the hope in helping whole genome overviews with many lines especially this branch, grape vs peach whole genome overview: main: |
might go ahead with merge :) |
0578cdf
to
6da562e
Compare
This performs a "Show all regions" operation for dotplot and synteny views
It also does some miscellaneous refactoring to make the header bar a bit less overwhelming, putting some of the "icons" (e.g. the chain icon for linking the views) into a submenu with text descriptions (because, chain icon isn't really obvious by itself)
Fixes #3380