Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to more easily create compact view of alignments #3384

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 7, 2022

Allows more easily toggling "normal" and "compact" settings for the pileup. Previously, we only had the "Set feature height" dialog, where the user would manually enter e.g. height:1 in a text box. The "compact" setting here is equal to setting height:2 and has "Remove y-spacing between features" to true

Screenshot from 2022-12-07 16-33-07

Screenshot from 2022-12-07 16-30-55

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3384 (f879eb8) into main (fa897bf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
- Coverage   60.04%   60.03%   -0.02%     
==========================================
  Files         777      777              
  Lines       29416    29421       +5     
  Branches     7117     7117              
==========================================
  Hits        17664    17664              
- Misses      11561    11566       +5     
  Partials      191      191              
Impacted Files Coverage Δ
...inearPileupDisplay/components/SetFeatureHeight.tsx 0.00% <0.00%> (ø)
...lugins/alignments/src/LinearPileupDisplay/model.ts 67.22% <0.00%> (-1.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 8, 2022
@cmdcolin cmdcolin merged commit bcb1b67 into main Dec 8, 2022
@cmdcolin cmdcolin deleted the easy_compact_alignments branch December 8, 2022 23:16
@cmdcolin
Copy link
Collaborator Author

Screenshot from 2022-12-12 18-59-54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant