Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter functionality on pileup tracks #2965

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix filter functionality on pileup tracks #2965

merged 2 commits into from
May 19, 2022

Conversation

cmdcolin
Copy link
Collaborator

The optimization for filterBy caused the filter reads function to break in the pileup track. This restores functionality by

  1. Using readName instead of name in the filter by read name function
  2. Recreating the layout after a filterBy is applied
  3. Serializing a clone of the filterBy object to make sure it gets recognized by observability systems when it is updated

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 19, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2965 (ebecc53) into main (8b9d869) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #2965      +/-   ##
==========================================
+ Coverage   60.67%   60.68%   +0.01%     
==========================================
  Files         601      601              
  Lines       27342    27345       +3     
  Branches     6654     6656       +2     
==========================================
+ Hits        16589    16594       +5     
+ Misses      10442    10441       -1     
+ Partials      311      310       -1     
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 64.97% <ø> (ø)
plugins/alignments/src/CramAdapter/CramAdapter.ts 83.94% <33.33%> (-0.62%) ⬇️
plugins/alignments/src/BamAdapter/BamAdapter.ts 72.97% <100.00%> (ø)
...ments/src/LinearSNPCoverageDisplay/models/model.ts 63.15% <100.00%> (+0.39%) ⬆️
...ignments/src/PileupRenderer/PileupLayoutSession.ts 100.00% <100.00%> (ø)
...ckages/core/pluggableElementTypes/RpcMethodType.ts 85.41% <0.00%> (+2.08%) ⬆️
...quenceRenderer/components/DivSequenceRendering.tsx 94.68% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9d869...ebecc53. Read the comment docs.

@cmdcolin cmdcolin merged commit c6b42a7 into main May 19, 2022
@cmdcolin cmdcolin deleted the fix_filter_by branch May 19, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant