Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize heights of widgets in LGV import form #2902

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Standardize heights of widgets in LGV import form #2902

merged 5 commits into from
Apr 14, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2861

Kinda picky but looks nicer this way

Explicitly provides a height to the AssemblySelector and the RefNameAutocomplete via InputProps

The git bisect showed that the cause of this was adding ScopedCssBaseline to @jbrowse/react-linear-genome-view which wasn't a huge hint but maybe hinted that things should be a bit more explicit

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 11, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2902 (1e9ff4b) into main (6e56875) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   59.92%   59.93%           
=======================================
  Files         587      587           
  Lines       26620    26621    +1     
  Branches     6474     6474           
=======================================
+ Hits        15953    15954    +1     
  Misses      10365    10365           
  Partials      302      302           
Impacted Files Coverage Δ
packages/core/ui/AssemblySelector.tsx 90.24% <ø> (ø)
...me-view/src/LinearGenomeView/components/Header.tsx 85.00% <ø> (ø)
...iew/src/LinearGenomeView/components/ImportForm.tsx 78.94% <100.00%> (+0.28%) ⬆️
.../linear-genome-view/src/LinearGenomeView/index.tsx 85.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56875...1e9ff4b. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

@cmdcolin cmdcolin merged commit 1e0c35d into main Apr 14, 2022
@cmdcolin cmdcolin deleted the lgv_height branch April 14, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LGV import form search box height in embedded does not match jbrowse-web/jbrowse-desktop
1 participant