Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-level synteny rubberband #2879

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Multi-level synteny rubberband #2879

merged 5 commits into from
Apr 6, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 6, 2022

Fixes #2658

I don't know if there is a good way to style it but I found it is maybe good not to be too visually intrusive, so in this example, it is invisible. But, if you mouse over it, a clearly visible vertical guide that goes over the full height of both views appears

localhost_3000__config=test_data%2Fconfig_synteny_grape_peach json session=local-Afiay0eI1 (3)

And then after clicking and dragging

localhost_3000__config=test_data%2Fconfig_synteny_grape_peach json session=local-Afiay0eI1

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 6, 2022
@cmdcolin cmdcolin added bug Something isn't working enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) bug Something isn't working labels Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #2879 (784f76f) into main (af7cc43) will decrease coverage by 0.28%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   59.98%   59.70%   -0.29%     
==========================================
  Files         590      591       +1     
  Lines       26631    26746     +115     
  Branches     6477     6510      +33     
==========================================
- Hits        15975    15968       -7     
- Misses      10352    10474     +122     
  Partials      304      304              
Impacted Files Coverage Δ
...mparativeView/components/LinearComparativeView.tsx 0.00% <0.00%> (ø)
...rc/LinearComparativeView/components/RubberBand.tsx 0.00% <0.00%> (ø)
...omparative-view/src/LinearComparativeView/model.ts 6.36% <0.00%> (-0.44%) ⬇️
...iew/src/LinearGenomeView/components/RubberBand.tsx 85.14% <100.00%> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 67.47% <0.00%> (-5.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7cc43...784f76f. Read the comment docs.

@cmdcolin cmdcolin force-pushed the synteny_rubberband branch from 399a3b3 to 784f76f Compare April 6, 2022 14:03
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 6, 2022

during chat with @rbuels he mentioned the invisible should be ok because the vertical guide is prominent. could consider adding selection to middle area too, but maybe can keep as is for now

@cmdcolin cmdcolin merged commit f365543 into main Apr 6, 2022
@cmdcolin cmdcolin deleted the synteny_rubberband branch April 6, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-level rubberband for synteny view
1 participant