Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on launching a deleted quickstart #2395

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2393

Catches errors in a nicer way, and filters out deleted quickstarts before trying to access them

There is a tension here between the observability, and fetching from the filesystem. We are not using mobx here, and since it is corresponding with the filesystem, and maybe even multiple instances of jbrowse, it wouldn't really be automatically solved by mobx, so this is just a best effort here to remain alive and consistent with the filesystem (again, it uses polling)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 12, 2021
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #2395 (8f7be08) into main (1870684) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   60.86%   60.88%   +0.01%     
==========================================
  Files         534      534              
  Lines       24634    24638       +4     
  Branches     5793     5794       +1     
==========================================
+ Hits        14994    15001       +7     
+ Misses       9324     9321       -3     
  Partials      316      316              
Impacted Files Coverage Δ
...browse-desktop/src/StartScreen/QuickstartPanel.tsx 0.00% <0.00%> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️
packages/core/util/index.ts 79.84% <0.00%> (ø)
packages/core/assemblyManager/assemblyManager.ts 68.42% <0.00%> (+1.31%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 100.00% <0.00%> (+3.44%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 88.04% <0.00%> (+11.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1870684...8f7be08. Read the comment docs.

@cmdcolin cmdcolin force-pushed the fix_deleted_quickstart branch from cb50945 to 8f7be08 Compare October 12, 2021 23:31
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 12, 2021
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 13, 2021
@cmdcolin cmdcolin merged commit ebdd085 into main Oct 13, 2021
@cmdcolin cmdcolin deleted the fix_deleted_quickstart branch October 13, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop crashes trying to open deleted quickstart
1 participant