Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @material-ui/core@4.12.2 #2141

Merged
merged 12 commits into from
Jul 21, 2021
Merged

Update to @material-ui/core@4.12.2 #2141

merged 12 commits into from
Jul 21, 2021

Conversation

cmdcolin
Copy link
Collaborator

This PR updates to @material-ui/core, lab, and data-grid, presumably getting bugfixes and improvements. I was actually interested in this though because I used jb2export and it printed the message

$ jb2export --fasta ~/src/gmod/jbrowse/docs/tutorial/data_files/volvox.fa --configtracks refseq --loc ctgA:1-100

Material-UI: the createMuiTheme function was renamed to createTheme.

You should use `import { createTheme } from '@material-ui/core/styles'`

This is somewhat interesting just because it shows we are getting an updated @material-ui/core when installing it with npm install -g @jbrowse/img. That makes sense because we don't necessarily pin versions

I tried updating to the latest @material-ui/core just to make sure that generally things work, in case this affects things like @jbrowse/linear-genome-view.

I did see an issue with upgrading where the accordion panels were transparent so I fixed that and upgraded the deps

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #2141 (61a4023) into main (c2aa053) will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   61.95%   61.98%   +0.02%     
==========================================
  Files         476      476              
  Lines       22763    22763              
  Branches     5344     5344              
==========================================
+ Hits        14103    14109       +6     
+ Misses       8379     8373       -6     
  Partials      281      281              
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 76.25% <ø> (ø)
packages/core/ui/DrawerWidget.js 94.28% <ø> (ø)
packages/core/ui/DropDownMenu.tsx 100.00% <ø> (ø)
packages/core/ui/ViewContainer.tsx 80.55% <ø> (ø)
packages/core/util/io/ElectronLocalFile.ts 3.33% <0.00%> (ø)
...r-view/src/CircularView/components/CircularView.js 90.90% <ø> (ø)
...ConfigurationEditorWidget/components/SlotEditor.js 63.82% <ø> (ø)
...lot-view/src/DotplotView/components/ImportForm.tsx 76.92% <ø> (ø)
...omparative-view/src/LinearComparativeView/model.ts 9.47% <ø> (ø)
...ew/src/LinearSyntenyView/components/ImportForm.tsx 0.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2aa053...61a4023. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 20, 2021
@rbuels rbuels merged commit 74954be into main Jul 21, 2021
@rbuels rbuels deleted the theme_update branch July 21, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants