Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouseovers/click handlers after "force load" button pressed #2131

Merged
merged 6 commits into from
Jul 15, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jul 14, 2021

This is probably a fix for #2130

SVG and pileup tracks have been updated

The blockLayoutFeatures concept is completely removed now

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 14, 2021
@cmdcolin cmdcolin requested a review from garrettjstevens July 14, 2021 21:19
@cmdcolin cmdcolin changed the title Fix mouseovers on svg track Fix missing mouseovers in some cases in pileup/svg tracks Jul 14, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #2131 (24851e5) into main (ec358f4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2131      +/-   ##
==========================================
- Coverage   61.99%   61.98%   -0.02%     
==========================================
  Files         476      476              
  Lines       22781    22773       -8     
  Branches     5351     5348       -3     
==========================================
- Hits        14123    14115       -8     
  Misses       8377     8377              
  Partials      281      281              
Impacted Files Coverage Δ
.../src/PileupRenderer/components/PileupRendering.tsx 78.21% <100.00%> (ø)
...aseLinearDisplay/models/BaseLinearDisplayModel.tsx 77.00% <100.00%> (-0.72%) ⬇️
...g/src/SvgFeatureRenderer/components/SvgOverlay.tsx 46.57% <100.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec358f4...24851e5. Read the comment docs.

@cmdcolin cmdcolin merged commit c2aa053 into main Jul 15, 2021
@cmdcolin cmdcolin deleted the fix_mouseovers_svg branch July 15, 2021 17:21
@cmdcolin cmdcolin changed the title Fix missing mouseovers in some cases in pileup/svg tracks Fix missing mouseovers after using "Force Load" button in zoomed out pileup/svg tracks Jul 29, 2021
@cmdcolin cmdcolin changed the title Fix missing mouseovers after using "Force Load" button in zoomed out pileup/svg tracks Fix mouseovers/click handlers after "Force Load" button pressed Jul 29, 2021
@cmdcolin cmdcolin changed the title Fix mouseovers/click handlers after "Force Load" button pressed Fix mouseovers/click handlers after "force load" button pressed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants