Fix bug where sometimes plugin could not be removed from UI

[garrettjstevens]

This fixes #2052 by not using the name at all when removing plugins and instead relying on the plugin URL to identify which plugin to remove.

[codecov]

Codecov Report

Merging #2115 (c746512) into main (b223419) will decrease coverage by 0.02%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
- Coverage   62.02%   62.00%   -0.03%     
==========================================
  Files         476      476              
  Lines       22789    22790       +1     
  Branches     5350     5350              
==========================================
- Hits        14134    14130       -4     
- Misses       8374     8379       +5     
  Partials      281      281              

Impacted Files	Coverage Δ
products/jbrowse-desktop/src/Loader.tsx	0.00% <ø> (ø)
products/jbrowse-desktop/src/jbrowseModel.js	17.80% <0.00%> (+0.24%)	⬆️
products/jbrowse-web/src/Loader.tsx	61.64% <ø> (ø)
products/jbrowse-web/src/jbrowseModel.js	57.44% <0.00%> (+0.60%)	⬆️
products/jbrowse-web/src/sessionModelFactory.ts	59.07% <0.00%> (ø)
...c/PluginStoreWidget/components/InstalledPlugin.tsx	63.15% <20.00%> (-3.51%)	⬇️
...nt/src/PluginStoreWidget/components/PluginCard.tsx	90.00% <66.66%> (-4.74%)	⬇️
...ginStoreWidget/components/InstalledPluginsList.tsx	84.61% <100.00%> (ø)
packages/core/PluginManager.ts	92.34% <0.00%> (-1.81%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b223419...c746512. Read the comment docs.

[elliothershberg]

Makes sense to me! These changes look good.

[cmdcolin]

You may be able to use pluginManager.runtimePluginDefinitions instead of looping over all plugins and looking at pluginMetadata.url. The pluginDefinitions have a URL, and were added specifically to support loading runtimePlugins on the webworker end, but should work for this issue too.

[garrettjstevens]

You may be able to use pluginManager.runtimePluginDefinitions instead of looping over all plugins and looking at pluginMetadata.url.

This PR does use runtimePluginDefinitions to check to see if a plugin is installed. It only loops over the session plugins and checks the metadata to differentiate between session and non-session runtime plugins.