Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service worker from jbrowse-web #2070

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2013

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 23, 2021
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #2070 (5792032) into main (eb0d220) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
+ Coverage   61.24%   61.42%   +0.17%     
==========================================
  Files         480      479       -1     
  Lines       22961    22909      -52     
  Branches     5267     5252      -15     
==========================================
+ Hits        14063    14071       +8     
+ Misses       8623     8563      -60     
  Partials      275      275              
Impacted Files Coverage Δ
products/jbrowse-web/src/index.tsx 0.00% <ø> (ø)
packages/core/assemblyManager/assemblyManager.ts 60.86% <0.00%> (+1.44%) ⬆️
packages/core/util/io/rangeFetcher.ts 92.68% <0.00%> (+2.43%) ⬆️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0d220...5792032. Read the comment docs.

@cmdcolin cmdcolin merged commit 9ac71b8 into main Jun 23, 2021
@cmdcolin cmdcolin deleted the remove_service_worker branch June 23, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix or get rid of service worker
1 participant