Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable app logo for web #2050

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Configurable app logo for web #2050

merged 4 commits into from
Jun 14, 2021

Conversation

elliothershberg
Copy link
Member

This is a small PR that adds a config slot to jbrowse-web for providing a custom logo. This should help with model organism communities who want to customize their app.

A quick way to test is to toss this config in config.json

"configuration": {
  "logoPath": {
    "uri": "/test_data/jb-logo.svg"
  }
}

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 14, 2021
@elliothershberg elliothershberg self-assigned this Jun 14, 2021
@elliothershberg elliothershberg added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #2050 (d269e9d) into main (9fc5d35) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files         473      473           
  Lines       22564    22569    +5     
  Branches     5251     5252    +1     
=======================================
+ Hits        13737    13741    +4     
- Misses       8545     8546    +1     
  Partials      282      282           
Impacted Files Coverage Δ
products/jbrowse-web/src/jbrowseModel.js 56.84% <ø> (ø)
packages/core/ui/App.js 78.78% <80.00%> (+0.21%) ⬆️
packages/core/util/index.ts 77.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc5d35...d269e9d. Read the comment docs.

@rbuels rbuels merged commit 96e4efe into main Jun 14, 2021
@rbuels rbuels deleted the configurable_app_icon branch June 14, 2021 18:50
} = session

function renderLogo() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style note: this concept of a "function that produces JSX" should really be it's own react component

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants