Add missing BoxRendererType exports #2047
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion #2042 helped me realize that we have some things missing in our re-exports in core. In this case, BoxRendererType was the default export in
packages/core/pluggableElementTypes/renderers/BoxRendererType.ts
, and inpackages/core/ReExports/modules.ts
it did:That meant that the named exports in BoxRendererType.ts didn't get added to
libs
. I don't think there's a way to add both named and default exports to a single entry inlibs
, so this PR changes BoxRendererType to a named export and then re-exports everything from that file.There could be other things missing in the same way, though. I'm wondering if there's a way to be more methodical about our re-exports to make sure we don't miss things. Or, we could ban default exports in core (like with a lint rule) to be sure this doesn't happen.