Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize the demo page to emphasize the cancer sv demo more #1976

Merged
merged 1 commit into from
May 19, 2021

Conversation

rbuels
Copy link
Contributor

@rbuels rbuels commented May 14, 2021

The cancer demo that takes people through the SV features gives grant reviewers a good overview of things without them having to do the work to click around, which I think is important right now.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 14, 2021
@rbuels rbuels added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1976 (9d94f5b) into main (690aee3) will increase coverage by 2.08%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   59.70%   61.79%   +2.08%     
==========================================
  Files         470      467       -3     
  Lines       22195    21883     -312     
  Branches     5097     5097              
==========================================
+ Hits        13252    13522     +270     
+ Misses       8641     8087     -554     
+ Partials      302      274      -28     
Impacted Files Coverage Δ
packages/core/data_adapters/BaseAdapter.ts 60.75% <0.00%> (ø)
products/jbrowse-desktop/src/rootModel.ts 36.11% <ø> (ø)
products/jbrowse-web/src/rootModel.ts 57.01% <ø> (ø)
products/jbrowse-cli/src/commands/add-track.ts 53.09% <63.15%> (+4.91%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/rpc/RpcManager.ts 83.87% <0.00%> (-3.63%) ⬇️
...pes/renderers/ComparativeServerSideRendererType.ts 64.28% <0.00%> (-1.24%) ⬇️
packages/core/util/compositeMap.ts 78.78% <0.00%> (-1.22%) ⬇️
packages/core/util/aborting.ts 84.00% <0.00%> (-1.19%) ⬇️
...ew/src/SpreadsheetView/importAdapters/BedImport.ts 31.74% <0.00%> (-1.07%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52c900...9d94f5b. Read the comment docs.

@cmdcolin
Copy link
Collaborator

@cmdcolin
Copy link
Collaborator

cmdcolin commented May 14, 2021

Another good addition to cancer demo would be to update this page and find a convincing breakpoint split view, because the one displayed has not much read evidence, and if possible, one that supports a gene fusion (with additional gene fusion RNA-seq type evidence displayed)

@rbuels
Copy link
Contributor Author

rbuels commented May 14, 2021

this PR doesn't change any of the links. is s3 being bad again?

@cmdcolin
Copy link
Collaborator

I don't believe this PR or anything did it, I think the demo just has gotten stale and contains some broken links

@rbuels rbuels merged commit f0b0019 into main May 19, 2021
@rbuels rbuels deleted the website_demos branch May 19, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants