Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analytics and share API URLs to refer to more stable locations #1932

Merged
merged 2 commits into from
May 3, 2021

Conversation

peterkxie
Copy link
Contributor

closes #1927
endpoints for analytics and sharing are now analytics.jbrowse.org and share.jbrowse.org

Used Route 53 to create the analytics and share subdomains of jbrowse.org

Both use alias redirects to Custom domain names in API Gateway under the same name

The custom domain names in API Gateway have API mappings to the existing endpoints that analytics and sharing sessions uses

@peterkxie peterkxie self-assigned this Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1932 (ff6c723) into main (e2b1261) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   58.74%   58.73%   -0.01%     
==========================================
  Files         460      460              
  Lines       21671    21671              
  Branches     5191     5191              
==========================================
- Hits        12730    12728       -2     
- Misses       8640     8642       +2     
  Partials      301      301              
Impacted Files Coverage Δ
products/jbrowse-web/src/jbrowseModel.js 59.75% <ø> (ø)
packages/core/util/analytics.ts 83.72% <100.00%> (ø)
products/jbrowse-web/src/Loader.tsx 59.07% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/util/index.ts 78.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b1261...ff6c723. Read the comment docs.

@rbuels
Copy link
Contributor

rbuels commented Apr 29, 2021

looks good to me, once we add a v1 to the analytics URL

@cmdcolin
Copy link
Collaborator

cmdcolin commented May 3, 2021

Example of the routes seen in API gateway

Uploading Screenshot from 2021-05-03 09-16-54.png…

@cmdcolin
Copy link
Collaborator

cmdcolin commented May 3, 2021

Example of the routes seen in API gateway

Screenshot from 2021-05-03 09-16-54

@cmdcolin
Copy link
Collaborator

cmdcolin commented May 3, 2021

Looks pretty good, I say we merge :)

@cmdcolin cmdcolin merged commit 4d42689 into main May 3, 2021
@cmdcolin cmdcolin changed the title Update Analytics and Share Endpoints For Clarity Update analytics and share API URLs to refer to more stable locations May 3, 2021
@cmdcolin cmdcolin deleted the 1927_update_endpoints branch January 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update analytics and session sharing endpoints to use a URL we can move
3 participants