-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualized tree for tracklist to support having thousands of tracks #1867
Conversation
…y not work, whodathunk
e62a519
to
44d655a
Compare
I tried adding a connection icon I guess while it satisfies the outline we made in the previous comment, I feel like the ux is still a bit weird. I put it on a separate branch for now. My feeling is that it is a bit better without. My reasoning is that hamburger menu fits user expectation better, people who are interested can locate a hamburger menu, but for the 99% of users it does not concern them as much Can try it out here once the codes are built |
…nto virtualized_tree
I went ahead and merged the power icon drop down for the connections after talked with @elliothershberg It now also pops up a dialog to toggle connections on and off The space was too cramped I think to properly toggle them via a submenu of that dropdown and any reasonably long connection name would go offscreen |
1a33aeb
to
8b9f86c
Compare
I'm looking over this now after pairing with @cmdcolin and thinking about any feedback from a usability perspective. I think overall, as @rbuels pointed out, this is a big performance win as track lists scale. A few smaller details:
vs. On that note, would it possible to give a little bottom margin to the individual sections so that there is a bit more breathing room between things? If it would be hacky to implement, might not be worth it. Those are the only small points I have on the UI. Always good to improve performance 💪 |
|
8b9f86c
to
322300e
Compare
This is a draft PR for using a virtualized tree for large tracklist rendering
Demos
volvox
http://s3.amazonaws.com/jbrowse.org/code/jb2/virtualized_tree/index.html?config=test_data%2Fvolvox%2Fconfig.json
1000 genomes data
http://s3.amazonaws.com/jbrowse.org/code/jb2/virtualized_tree/index.html?config=https%3A%2F%2Fs3.amazonaws.com%2Fjbrowse.org%2Fgenomes%2FGRCh38%2F1000genomes%2Fconfig_1000genomes.json&session=share-SUK-mntGyB&password=eQF0F
Todos include restoring "Add track" and "Add connection" button, adding the "track actions" (...) after tracks, and possible user-interface prettying
Any early feedback welcome
Probably we will not have text wrapping as a compromise for simplicity, and we will have a slightly side-scrollable list
Fixes #728